Unused columns in WHERE clause

All we need is an easy explanation of the problem, so here it is.

I found this query in our codebase:

DELETE FROM "Foo"
WHERE ("Foo"."Id", "Foo"."CreatedAt")
IN (SELECT "f"."Id", "f"."CreatedAt"
    FROM "Foo" AS "f"
    WHERE "f"."CreatedAt" <= CURRENT_TIMESTAMP);

It deletes records created before the current time.

This gives the same result:

DELETE FROM "Foo"
WHERE "Foo"."CreatedAt"
IN (SELECT "f"."CreatedAt"
    FROM "Foo" AS "f"
    WHERE "f"."CreatedAt" <= CURRENT_TIMESTAMP);

I don’t know why the Foo.Id is included in the WHERE clause – maybe leftover junk from various refactorings (e.g. it could have been used for batch delete with ORDER BY "f"."Id" LIMIT 1000). But because it’s a PK, I’m reluctant to remove it, as maybe it’s there for a reason.

Is there a theoretical / perf reason for having it in there, or are the two queries equivalent?

(This targets both postgres and sqlite.)

How to solve :

I know you bored from this bug, So we are here to help you! Take a deep breath and look at the explanation of your problem. We have many solutions to this problem, But we recommend you to use the first method because it is tested & true method that will 100% work for you.

Method 1

Both queries are ridiculously complicated. Use

DELETE FROM "Foo"
WHERE "CreatedAt" < current_timestamp;

Note: Use and implement method 1 because this method fully tested our system.
Thank you 🙂

All methods was sourced from stackoverflow.com or stackexchange.com, is licensed under cc by-sa 2.5, cc by-sa 3.0 and cc by-sa 4.0

Leave a Reply